From: Sebastian Keller <skeller@gnome.org>
Date: Wed, 22 Jan 2020 22:34:23 +0000 (+0100)
Subject: st/icon: Fix GIcon leak in set_fallback_icon_name
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~781^2^2~141
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=b49023c31cd38036015a5e637f88f7e5bd2d8029;p=gnome-shell.git

st/icon: Fix GIcon leak in set_fallback_icon_name

set_fallback_icon_name() leaks a GIcon by using the set_icon method
which adds a ref to the GIcon without removing its own ref after calling
the method.

Related to https://gitlab.gnome.org/GNOME/gnome-shell/issues/2146
---

diff --git a/src/st/st-icon.c b/src/st/st-icon.c
index 70e4fb46c..090ba4b10 100644
--- a/src/st/st-icon.c
+++ b/src/st/st-icon.c
@@ -726,7 +726,7 @@ void
 st_icon_set_fallback_icon_name (StIcon      *icon,
                                 const gchar *fallback_icon_name)
 {
-  GIcon *gicon = NULL;
+  g_autoptr(GIcon) gicon = NULL;
 
   g_return_if_fail (ST_IS_ICON (icon));